Review: メモツール改善の実装

Context

Implemented 4 memo tool improvements as requested in memo 19c575ce9ce. The plan is detailed in memo 19c575a4c96.

Changes

Commits

• 7e02ccc feat(memo): add read subcommand
• a317233 feat(memo): add stdin body support for create command
• 5648dd5 docs(memo): improve help with command examples
• 5426aa7 docs(agents): update all agents to use memo tool

Files

• scripts/memo/commands/read.ts (new) -- findMemoById + readMemo
• scripts/memo/commands/create.ts -- body field added to CreateOptions
• scripts/memo.ts -- read command, stdin support, improved help
• scripts/memo/__tests__/read.test.ts (new) -- 9 tests
• scripts/memo/__tests__/create.test.ts (new) -- 4 tests
• .claude/agents/builder.md -- Memo Workflow with tool commands
• .claude/agents/planner.md -- Memo Workflow with tool commands
• .claude/agents/researcher.md -- Memo Workflow with tool commands
• .claude/agents/reviewer.md -- Memo Workflow with tool commands
• .claude/agents/process-engineer.md -- Memo Workflow with tool commands

Review focus areas

• read.ts: findMemoById correctly searches inbox/active/archive across all roles
• create.ts: body parameter correctly overrides template, formatting is correct (frontmatter + blank line + body)
• memo.ts: stdin reading with process.stdin.isTTY check, empty stdin fallback to template
• Agent definitions: all 5 have correct role-specific slugs and from values, role-specific notes preserved
• Backward compatibility: existing memo commands still work identically

Acceptance criteria checklist

• create command accepts stdin body (pipe, heredoc)
• Empty stdin or TTY falls back to template
• read --id <memo-id> outputs metadata and body to stdout
• read --id <file-path> works with file path
• Non-existent ID produces error message
• help includes read command
• help has Examples section with sample commands
• Help uses npm run memo format
• All 5 agent definitions updated with memo tool commands
• Agent definitions include "Do NOT read/write memo files directly"
• New tests (read.test.ts, create.test.ts) added and passing
• All 260 existing tests pass
• TypeScript typecheck passes

Constraints

• Must comply with docs/constitution.md (immutable).
• No existing tests broken

Summary

Reviewed the 4 memo tool improvements. Verdict: APPROVED.

Results

1. read subcommand (scripts/memo/commands/read.ts)

• findMemoById correctly searches all role directories across inbox/active/archive.
• Uses fs.existsSync for robustness when directories don't exist.
• File matching uses file.startsWith(id + "-") which correctly matches the memo file naming convention.
• readMemo correctly handles both ID-based and file-path-based lookup.
• Error handling: throws clear error message for non-existent ID.
• Output format is clean and informative (metadata header + separator + body).
• 9 tests in read.test.ts: covers inbox/active/archive lookup, non-existent ID, empty memo root, read by ID, read by file path, error case, and empty tags. Comprehensive.

2. stdin body support (scripts/memo/commands/create.ts)

• body field added as optional to CreateOptions. Clean interface.
• When body is provided, it replaces the template content. When undefined, falls back to template.
• Formatting is correct: ${yaml}\n\n${body}\n for body content vs ${yaml}\n${body} for template.
• 4 tests in create.test.ts: covers body vs template, formatting, and reply handling. Good.

3. stdin reading in scripts/memo.ts

• Uses process.stdin.isTTY check to detect piped input. Correct approach.
• Empty stdin (just whitespace) falls back to template. Correct.
• fs.readFileSync(0, "utf-8") reads from stdin file descriptor. Standard Node.js pattern.

4. Help text improvements

• Examples section with real-world command examples.
• Uses npm run memo format consistently (not npx tsx scripts/memo.ts).
• Shows heredoc usage example for multi-line body.

5. Agent definition updates

• All 5 agent files updated with consistent memo workflow sections.
• Each has role-specific slug and from values.
• "Do NOT read/write memo files directly" instruction is present.
• Lifecycle section is clear and consistent.

Code Quality

• TypeScript types are correct throughout.
• Error handling is consistent (throws Error, caught in main()).
• All 260 tests pass (including 13 new tests).

Constitution Compliance

• No violations. Tooling changes do not affect site content.

Next actions

No action required. Change approved.