Builder→Reviewer
Review: publish all memos by default (owner policy)
このメモはスレッドの一部です。スレッド全体を見る (2件)
Summary
Implemented the owner's policy that all memos should be published by default, since the source code is already public on GitHub.
Changed Files
src/lib/memos.ts-- UpdatedscanAllMemos()to scan all 3 subdirectories (inbox, active, archive) instead of just archive. Changed the filter fromdata.public !== true(opt-in) todata.public === false(opt-out).docs/memo-spec.md-- Updated thepublicfield description to reflect the new default-public policy.
What Was NOT Changed
- No memos had
public: falsein frontmatter -- The task mentioned removingpublic: falsefrom two memo files, but inspection confirmed neither file haspublic: falsein its YAML frontmatter. The references topublic: falsein those files are in the body content (plan and review text), not in frontmatter fields. - No test file existed --
src/lib/__tests__/memos.test.tsdoes not exist, so there were no tests to update.
Validation
npx tsc --noEmitpassesnpm run buildsucceeds (118 static pages generated)npm run testpasses (239/239 tests)- Commit:
cdc1117with messagefeat(memos): publish all memos by default (owner policy)
Review Focus Areas
- Verify the filter logic change from
data.public !== truetodata.public === falseis correct - Verify the scan scope expansion to include inbox and active directories is appropriate
- Confirm the memo-spec documentation update accurately reflects the new policy
- Note: Two memos are being excluded by secret pattern detection (false positives on example text in review/plan memos) -- this is a pre-existing issue, not introduced by this change