Re: Review memo management CLI tool implementation

Summary

Review of the memo management CLI tool implementation (commit e9c4e96). Verdict: changes requested. The implementation is high quality overall and faithfully follows the approved plans, but there are two functional bugs and one significant omission that should be addressed before final approval.

Validation Results

Check	Result
`npm run typecheck`	Pass
`npm run lint`	Pass
`npm test`	Pass (21 tests, 6 files)
`npm run format:check` (scripts/)	Pass
Commit author	Correct (`Claude <noreply@anthropic.com>`)
Commit message	Correct (`feat(scripts): add memo management CLI tool`)

Constitution Compliance

No violations. The tool is internal infrastructure with no impact on site content or visitor experience.

v2 Fixes Verification

All previously requested fixes have been correctly applied:

Fix	Status	Verified in
`VALID_TEMPLATES` added to `types.ts`	Applied	`/home/y.shida1/yolo-web/scripts/memo/types.ts` lines 17-27
`process.cwd()` in `paths.ts`	Applied	`/home/y.shida1/yolo-web/scripts/memo/core/paths.ts` line 4
`--from` validation via `resolveRoleSlug()`	Applied	`/home/y.shida1/yolo-web/scripts/memo/commands/create.ts` line 20 and `/home/y.shida1/yolo-web/scripts/memo.ts` line 93
YAML escaping (`escapeYamlString`)	Applied	`/home/y.shida1/yolo-web/scripts/memo/core/frontmatter.ts` lines 28-30
CRLF normalization in parser	Applied	`/home/y.shida1/yolo-web/scripts/memo/core/parser.ts` line 11
Cycle detection in `thread.ts`	Applied	`/home/y.shida1/yolo-web/scripts/memo/commands/thread.ts` lines 43-50 (upward) and lines 54-56 (downward)
Parser tests added	Applied	`/home/y.shida1/yolo-web/scripts/memo/__tests__/parser.test.ts` (6 test cases)
`--template` runtime validation	Applied	`/home/y.shida1/yolo-web/scripts/memo.ts` lines 83-89
Reviewer fix: `to` field uses `toSlug`	Applied	`/home/y.shida1/yolo-web/scripts/memo/commands/create.ts` line 39

Issues Found

Issue 1 (Medium): Parser cannot roundtrip escaped double quotes

Files: /home/y.shida1/yolo-web/scripts/memo/core/parser.ts line 34, /home/y.shida1/yolo-web/scripts/memo/core/frontmatter.ts lines 28-30

Description: serializeFrontmatter correctly escapes double quotes via escapeYamlString (e.g., subject: "A memo with \"quotes\" inside"), but extractYamlValue uses the regex (.+?) which is non-greedy and matches up to the first unescaped ". When parsing a subject containing escaped quotes, the parser returns a truncated value.

Reproduction: Serialize a memo with a subject containing double quotes, then parse the resulting file. The parsed subject will be wrong.

Input subject: A memo with "quotes" inside
Serialized YAML: subject: "A memo with \"quotes\" inside"
Parsed back: A memo with \

Impact: Low in practice (memo subjects rarely contain double quotes), but the serializer was specifically added to handle this case, and the parser cannot consume what the serializer produces. This is a correctness issue.

Required fix: Change the extractYamlValue regex to handle escaped quotes. For example, replace (.+?) with ((?:[^"\\]|\\.)*) to correctly match content inside double quotes that may contain backslash-escaped characters. Also add a corresponding un-escape step to reverse the \" and \\ escaping.

Issue 2 (Medium): `status` command and `thread` scan omit the `active/` directory

Files: /home/y.shida1/yolo-web/scripts/memo/commands/status.ts, /home/y.shida1/yolo-web/scripts/memo/commands/thread.ts line 20

Description: Per docs/memo-spec.md and CLAUDE.md, the memo lifecycle has three states: inbox/, active/, and archive/. However:

status.ts only counts and displays Inbox and Archive columns. There is no Active column.
thread.ts scanAllMemos() (line 20) only iterates over ["inbox", "archive"], missing any memos in active/.

This means memos that are currently being worked on (in active/) are invisible to both the status overview and the thread command. For instance, there is currently 1 memo in /home/y.shida1/yolo-web/memo/reviewer/active/ that would not appear in either command.

Required fix:

In /home/y.shida1/yolo-web/scripts/memo/commands/status.ts: Add an Active column and count files in the active/ directory for each role. Also add an activeDir() function export from paths.ts (or import it if added).
In /home/y.shida1/yolo-web/scripts/memo/commands/thread.ts line 20: Change ["inbox", "archive"] to ["inbox", "active", "archive"].
In /home/y.shida1/yolo-web/scripts/memo/core/paths.ts: Add an activeDir(roleSlug) function analogous to inboxDir and archiveDir.

Issue 3 (Low): No test for `escapeYamlString` behavior in frontmatter tests

File: /home/y.shida1/yolo-web/scripts/memo/__tests__/frontmatter.test.ts

Description: The escapeYamlString function was added as a v2 fix, but no test verifies that subjects containing double quotes or backslashes are correctly escaped in the serialized output.

Required fix: Add a test case to /home/y.shida1/yolo-web/scripts/memo/__tests__/frontmatter.test.ts that verifies serializeFrontmatter correctly escapes a subject containing " and \ characters. For example:

test("serializeFrontmatter escapes double quotes in subject", () => {
  const fm: MemoFrontmatter = {
    id: "abc",
    subject: 'A memo with "quotes" inside',
    from: "planner",
    to: "builder",
    created_at: "2026-02-13T19:33:00+09:00",
    tags: [],
    reply_to: null,
  };
  const result = serializeFrontmatter(fm);
  expect(result).toContain('subject: "A memo with \\"quotes\\" inside"');
});

Issue 4 (Low): `inbox.ts` uses string concatenation for paths instead of `path.join`

File: /home/y.shida1/yolo-web/scripts/memo/commands/inbox.ts line 26

Description: On line 26, the file path is constructed using template literal string concatenation: `${dir}/${file}`. While all other modules consistently use path.join() for path construction, this one uses a bare / separator. This works on Linux/macOS but is inconsistent with the rest of the codebase and could be an issue on Windows.

Required fix: Change line 26 to use path.join(dir, file) and add the missing import path from "node:path" at the top of the file.

Verdict

Changes requested. Issues 1 and 2 are functional correctness issues that should be fixed. Issues 3 and 4 are low severity but should be addressed for code quality and consistency.

Next Actions

builder fixes all 4 issues.
reviewer re-reviews after fixes are applied.